Skip to content

xi-search#26 - Linting via Standard

Yannick Leyendecker requested to merge feature/26-standard into develop

Steps to review

  1. npm install
  2. npm run lint
  3. Fix linting errors (globals can be defined in package.json)
  4. Commit fixed changes
  5. Make sure Standard is linting your changed files

Outstanding errors

✖ standard --fix:
standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  ./src/App.test.js:5:1: 'test' is not defined.
  ./src/App.test.js:8:3: 'expect' is not defined.
  ./src/components/devComponents/themeSelector/index.js:12:19: 'localStorage' is not defined.
  ./src/components/devComponents/themeSelector/index.js:18:5: 'localStorage' is not defined.
  ./src/lib/components.config.example.js:11:7: Identifier 'searchinfo_markup' is not in camel case.
  ./src/lib/components.config.example.js:49:3: Identifier 'searchinfo_markup' is not in camel case.
  ./src/lib/config.js:26:7: Identifier 'menu_search' is not in camel case.
  ./src/lib/config.js:67:7: 'frontpage' is assigned a value but never used.
  ./src/lib/config.js:106:7: Identifier 'all_search' is not in camel case.
  ./src/lib/config.js:106:7: 'all_search' is assigned a value but never used.
  ./src/lib/drupal.bridge.js:5:19: Identifier 'drupal_formatString' is not in camel case.
  ./src/lib/drupal.bridge.js:9:7: 'foo' is assigned a value but never used.
  ./src/lib/drupal.bridge.js:18:17: Expected newline between test and consequent of ternary expression.
  ./src/lib/drupal.bridge.js:18:56: Expected newline between consequent and alternate of ternary expression.
  ./src/lib/drupal.bridge.js:32:3: Expected closing tag to match indentation of opening.
  ./src/lib/drupal.bridge.js:38:3: Expected closing tag to match indentation of opening.
  ./src/lib/json_data.js:16:3: 'fetch' is not defined.
  ./src/lib/json_data.js:64:27: 'localStorage' is not defined.
  ./src/lib/json_data.js:64:70: 'sessionStorage' is not defined.
  ./src/lib/json_data.js:75:47: 'localStorage' is not defined.
  ./src/lib/json_data.js:75:103: 'sessionStorage' is not defined.
  ./src/lib/query.helper.js:5:16: Expected 'undefined' and instead saw 'void'.
  ./src/serviceWorker.js:103:3: 'fetch' is not defined.
Edited by Yannick Leyendecker

Merge request reports